Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect layout on grid load in one column mode #2531

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

adumesny
Copy link
Member

Description

  • fix Incorrect layout on grid load in one column mode #2527
  • turned out to be much more complicated fix than expected. cleanup some of the code while debugging through it...
  • make sure we nodeBoundFix() before widthChanged is checked
  • cacheLayout() now checks fo existing node id so loading again doesn't mess things up

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* fix gridstack#2527
* turned out to be much more complicated fix than expected. cleanup some of the code while debugging through it...
* make sure we nodeBoundFix() before widthChanged is checked
* cacheLayout() now checks fo existing node id so loading again doesn't mess things up
@adumesny adumesny merged commit 62a1fb8 into gridstack:master Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect layout on grid load in one column mode
1 participant