Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sizeToContent fixes (animation, DOM init, cleanup) #2561

Merged
merged 1 commit into from
Dec 9, 2023
Merged

sizeToContent fixes (animation, DOM init, cleanup) #2561

merged 1 commit into from
Dec 9, 2023

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Dec 9, 2023

Description

Also:

  • fixed drag&drop not calling size either
  • prevent animation when loading (from empty) and when replacing placeholder with actual content (helps in sizeToContent)
  • resizeToContent() no longer use dic sizing (only node.h) so we rarely have to delay for animation (only when column widget changes)
  • bunch of renames (internal) to make cleaner.

*** POSSIBLE BREAK (unlikely)

  • ResizeToContentFcn doesn't take optional useAttr arg anymore

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
sizeToContent fixes (animation, DOM init, cleanup)
d9e575b 
* fix gridstack#2552 where dom init wasn't calling sizeToContent

Also:
* fixed drag&drop not calling size either
* prevent animation when loading (from empty) and when replacing placeholder with actual content (helps in sizeToContent)
* resizeToContent() no longer use dic sizing (only node.h) so we rarely have to delay for animation (only when column widget changes)
* bunch of renames (internal) to make cleaner.

*** POSSIBLE BREAK (unlikely)
* ResizeToContentFcn doesn't take optional useAttr arg anymore
@adumesny adumesny merged commit 6e537a4 into gridstack:master Dec 9, 2023
adumesny added a commit to adumesny/gridstack.js that referenced this pull request Dec 10, 2023
@adumesny
more sizeToContent fixes
33853b9 
* tweak to gridstack#2561
* drap&drop not having added element)
This was referenced Dec 10, 2023
Merged
Closed
@Samg217 Samg217 mentioned this pull request Jul 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sizeToContent is not triggered when initializing from HTML
1 participant
@adumesny