Allow cell height in cm and mm units #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
reviewed
Dec 13, 2023
| @@ -219,7 +219,7 @@ export class Utils { | |||
| if (typeof val === 'string') { | |||
| if (val === 'auto' || val === '') h = 0; | |||
| else { | |||
| let match = val.match(/^(-[0-9]+\.[0-9]+|[0-9]*\.[0-9]+|-[0-9]+|[0-9]+)(px|em|rem|vh|vw|%)?$/); | |||
| let match = val.match(/^(-[0-9]+\.[0-9]+|[0-9]*\.[0-9]+|-[0-9]+|[0-9]+)(px|em|rem|vh|vw|%|cm|mm)?$/); | |||
There was a problem hiding this comment.
do browser support cm ? and how would I convert this to px to do match (which I do for rem/em)
There was a problem hiding this comment.
Browsers do support cm/mm. You can see the spec here: https://www.w3.org/TR/css-values-3/#absolute-lengths
There's also a conversion rate given for cm to px. I updated the getCellHeight method to accommodate for cm/mm units
joostme
force-pushed
the
patch-1
branch
2 times, most recently
from
4bcff85
to
2ffb301
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
cmandmmunits for cell height. I am using this to create a printable layout that's consistent across devices when printing on paper. The only way to achieve that is by usingcmandmmunits. This small PR allows the two additional CSS units.Checklist
yarn test)