Feature/216/destroy param #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $(window).off('resize', this.onResizeHandler); | ||
| this.disable(); | ||
| this.container.remove(); | ||
| if (typeof detachGrid != 'undefined' && !detachGrid) { | ||
| this.removeAll(true); |
There was a problem hiding this comment.
Shouldn't this be false? Otherwise, when detachGrid === false, we won't remove the grid container, but we will remove all of the widgets.
There was a problem hiding this comment.
You're absolutely correct. This should be this.removeAll(false). We're in the process of adding in unit tests, and clearly have not added this yet. Apologies for the mixup - I'll fix this and have it pushed out momentarily. Thanks for finding and reporting this bug - saved someone lots of frustration down the road. I hope this didn't cause you much issue.
There was a problem hiding this comment.
This has been updated. Thank you again for finding this!
There was a problem hiding this comment.
Sweet! Thanks for the quick turnaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#216