Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add list of ids to contingency info export endpoint #102

Merged
merged 10 commits into from
Jul 10, 2024
Merged

add list of ids to contingency info export endpoint #102

merged 10 commits into from
Jul 10, 2024

Conversation

jamal-khey
Copy link
Contributor

@jamal-khey jamal-khey commented Jul 1, 2024 •
edited
Loading

@jamal-khey jamal-khey requested a review from antoinebhs July 2, 2024 11:45
@jamal-khey jamal-khey mentioned this pull request Jul 3, 2024
Merged
@sBouzols sBouzols self-requested a review July 3, 2024 09:51
antoinebhs
antoinebhs requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with sensitivity-analysis-server: https://github.com/gridsuite/sensitivity-analysis-server/blob/4350f48fac079443b9d3fb4551bc5920446b8110/src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java#L60-L62
Can we fix it in the mean time for the endpoint /contingency-lists/{id}/export (@SlimaneAmar)?

src/main/java/org/gridsuite/actions/server/ContingencyListController.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/actions/server/ContingencyListController.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/actions/server/ContingencyListController.java Show resolved Hide resolved
src/main/java/org/gridsuite/actions/server/ContingencyListController.java Show resolved Hide resolved
@SlimaneAmar
Copy link
Contributor

Same issue with sensitivity-analysis-server: https://github.com/gridsuite/sensitivity-analysis-server/blob/4350f48fac079443b9d3fb4551bc5920446b8110/src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java#L60-L62 Can we fix it in the mean time for the endpoint /contingency-lists/{id}/export (@SlimaneAmar)?

Yes

sBouzols
sBouzols reviewed Jul 4, 2024
View reviewed changes
src/main/java/org/gridsuite/actions/server/ContingencyListService.java Outdated
@@ -173,6 +173,12 @@ public List<ContingencyInfos> exportContingencyInfosList(UUID id, UUID networkUu
return evaluateContingencyList(findContingencyList(id, network), network);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove previous exportContingencyInfosList definition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@jamal-khey jamal-khey changed the title add list of ids to contingency info export endpoint [WIP] add list of ids to contingency info export endpoint Jul 8, 2024
@jamal-khey jamal-khey changed the title [WIP] add list of ids to contingency info export endpoint add list of ids to contingency info export endpoint Jul 8, 2024
@jamal-khey jamal-khey self-assigned this Jul 8, 2024
@jamal-khey jamal-khey requested review from antoinebhs and sBouzols July 8, 2024 13:53
@jamal-khey jamal-khey changed the title add list of ids to contingency info export endpoint WIP add list of ids to contingency info export endpoint Jul 8, 2024
@jamal-khey jamal-khey changed the title WIP add list of ids to contingency info export endpoint add list of ids to contingency info export endpoint Jul 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jamal-khey jamal-khey merged commit 20bd5de into main Jul 10, 2024
3 checks passed
@jamal-khey jamal-khey deleted the jamal-khey/add-contengency-info-export-endpoint-for-lists branch July 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinebhs antoinebhs antoinebhs approved these changes

@sBouzols sBouzols sBouzols approved these changes

Assignees

@jamal-khey jamal-khey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamal-khey @SlimaneAmar @sBouzols @antoinebhs