[WIP] Clean orphan elements script #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for now Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier@rte-france.com>
klesaulnier
changed the title
SlimaneAmar
requested changes
Aug 4, 2023
| print("Getting existing networks from existing studies") | ||
| get_studies_response = requests.get(constant.GET_STUDIES) | ||
|
|
||
| get_studies_response_json = get_studies_response.json() |
There was a problem hiding this comment.
Use a form more concise and more readable ?
existing_networks_uuid = [study["networkUuid"] for study in get_studies_response.json()]
| print("Getting networks from network store server") | ||
| get_networks_response = requests.get(constant.GET_NETWORKS) | ||
|
|
||
| get_networks_response_json = get_networks_response.json() |
There was a problem hiding this comment.
Use a form more concise and more readable ?
all_networks_uuid = [network["uuid"] for network in get_networks_response.json()]
|
|
||
| get_studies_response_json = get_studies_response.json() | ||
| get_studies_response_json_network_uuid = map(get_network_uuid_from_study, get_studies_response_json) | ||
| existing_networks_uuid = list(get_studies_response_json_network_uuid) |
|
|
||
| get_networks_response_json = get_networks_response.json() | ||
| get_networks_response_json_uuid = map(get_network_uuid_from_network, get_networks_response_json) | ||
| all_networks_uuid = list(get_networks_response_json_uuid) |
| print("Done") | ||
| # GET NETWORKS SAVED IN NETWORK STORE SERVER | ||
| print("Getting networks from network store server") | ||
| get_networks_response = requests.get(constant.GET_NETWORKS) |
There was a problem hiding this comment.
Add this to deal with errors
if not get_studies_response.ok:
get_studies_response.raise_for_status()
|
I think we need a logger to log infos in a file to analyze the logs and detect possible bugs |
SlimaneAmar
reviewed
Sep 18, 2023
| @@ -0,0 +1,26 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Add new package clean_computation_results
|
Code duplication: the three functions are almost identical and differ only by the type of elements |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.