-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: move all scripts in a folder #17
Conversation
COPY all the scripts folder in Docker image WORKDIR Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
26026b5
to
f8e6cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test OK
Code OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code OK
Tests OK (with local image and with python directly)
@@ -50,16 +50,16 @@ All post requests are sent with the header "X-Disable-Provenance" set to "true". | |||
First, we need to create a folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it could be nice to show the possibility to run a different script locally with a container:
docker run admin-tools python delete_indexed_equipments.py -n
in addition to docker run admin-tools
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice will add it to the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
COPY all the scripts folder in Docker image WORKDIR