Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move all scripts in a folder #17

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

sBouzols
Copy link
Contributor

@sBouzols sBouzols commented Jun 7, 2024

COPY all the scripts folder in Docker image WORKDIR

COPY all the scripts folder in Docker image WORKDIR

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
@sBouzols sBouzols force-pushed the refactor_scripts_dockerfile branch from 26026b5 to f8e6cb0 Compare June 7, 2024 20:32
Copy link
Collaborator

@klesaulnier klesaulnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK
Code OK

Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Tests OK (with local image and with python directly)

@@ -50,16 +50,16 @@ All post requests are sent with the header "X-Disable-Provenance" set to "true".
First, we need to create a folder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could be nice to show the possibility to run a different script locally with a container:
docker run admin-tools python delete_indexed_equipments.py -n in addition to docker run admin-tools ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice will add it to the README

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
@sBouzols sBouzols merged commit b54ef53 into main Jun 10, 2024
2 checks passed
@sBouzols sBouzols deleted the refactor_scripts_dockerfile branch June 10, 2024 09:13
jonenst pushed a commit that referenced this pull request Jan 17, 2025
)

* refactor(): Move all scripts in a folder
COPY all the scripts folder in Docker image WORKDIR

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants