imlement scoring in elk for search elements #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…search # Conflicts: # src/main/java/org/gridsuite/directory/server/repository/DirectoryElementRepository.java # src/main/java/org/gridsuite/directory/server/services/DirectoryRepositoryService.java
jamal-khey
changed the title
…search # Conflicts: # src/main/java/org/gridsuite/directory/server/DirectoryService.java
|
I think the best mapping of a path is with field type : keyword |
|
Need complete tests for scoring with all cases |
SlimaneAmar
requested changes
Jul 2, 2024
| @@ -58,6 +58,9 @@ public class DirectoryElementInfos { | |||
| @Field(type = FieldType.Date, format = DateFormat.date_time) | |||
| Instant lastModificationDate; | |||
|
|
|||
| @Field(type = FieldType.Text) | |||
jamal-khey
commented
Jul 5, 2024
| .toList(); | ||
| public List<DirectoryElementInfos> searchElements(@NonNull String userInput, String directoryUuid) { | ||
| return directoryElementInfosService.searchElements(userInput, directoryUuid) | ||
| .stream().filter(element -> isElementExists(element.getParentId())) // filter the Orphan elements |
There was a problem hiding this comment.
@SlimaneAmar in case of deletion of a directory , we can still have Orphans
// root
// / \
// dir1 (deleted but keeping its sub-elements) dir2
directoryElementRepository.deleteById(subDirUuid1);`
…into jamal-khey/store-path-in-elastic-search
code refactoring
|
SlimaneAmar
approved these changes
Jul 10, 2024
| public List<DirectoryElementInfos> searchElements(@NonNull String userInput, String currentDirectoryUuid) { | ||
|
|
||
| // We dont want to show the directories | ||
| Query directory = TermQuery.of(m -> m |
There was a problem hiding this comment.
Queries.termQuery(ELEMENT_TYPE, DIRECTORY)._toQuery() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test this PR run :
to test and adjust boost go to : http://localhost:5601/app/dev_tools#/console
in the elastic search does not recommend using wildcard with a * in the beging, because This can increase the iterations needed to find matching terms and slow search performance.
to find how the score is computed use GET /directory-elements/_explain/doccumentId