Move directory #162
Merged
Move directory #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2024 11:15
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
added 2 commits
September 25, 2024 00:05
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
jamal-khey
reviewed
Sep 30, 2024
souissimai
requested changes
Oct 1, 2024
| notifyDirectoryHasChanged(oldDirectory.getId(), userId, element.getName()); | ||
|
|
||
| } | ||
|
|
||
| private void validateElementForMove(DirectoryElementEntity element, UUID newDirectoryUuid, String userId) { | ||
| if (element.getType().equals(DIRECTORY)) { | ||
| throw new DirectoryException(IS_DIRECTORY); | ||
| if (Objects.equals(element.getType(), DIRECTORY) && element.getParentId() == null) { |
There was a problem hiding this comment.
element.getType can be null? why using Objects.equals
| @@ -586,9 +586,29 @@ public void testMoveDirectory() throws Exception { | |||
| .header("userId", "Doe") | |||
| .contentType(MediaType.APPLICATION_JSON) | |||
| .content(objectMapper.writeValueAsString(List.of(directory21UUID)))) | |||
| .andExpect(status().isForbidden()); | |||
| .andExpect(status().isOk()); | |||
There was a problem hiding this comment.
add rootdirectory case? forbidden
added 11 commits
October 2, 2024 14:30
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
SlimaneAmar
approved these changes
Oct 15, 2024
|
Just need a test to move a root directory |
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
|
Remove Sonar issue ! |
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
jamal-khey
reviewed
Oct 17, 2024
Comment on lines
335
to
337
| if (element.getParentId() == newDirectoryUuid) { // Same directory ? | ||
| return; | ||
| } |
There was a problem hiding this comment.
small bug here , '==' does not work on uuids
Suggested change
| if (element.getParentId() == newDirectoryUuid) { // Same directory ? | |
| return; | |
| } | |
| if (element.getParentId().equals(newDirectoryUuid)) { // Same directory ? | |
| return; | |
| } |
may be we need a small unit test for this case also ?
There was a problem hiding this comment.
done, i used Objects.equals(element.getParentId(), newDirectoryUuid) because parentId could be null
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
jamal-khey
approved these changes
Oct 17, 2024
|
souissimai
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.