get composite modification content endpoint #102
Conversation
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
| @@ -249,6 +249,15 @@ public ResponseEntity<List<ElementAttributes>> getElementsMetadata(@RequestParam | |||
| return ResponseEntity.ok().contentType(MediaType.APPLICATION_JSON).body(directoryService.getElementsMetadata(ids, elementTypes, equipmentTypes)); | |||
| } | |||
|
|
|||
| @GetMapping(value = "/explore/composite-modification/{id}", produces = MediaType.APPLICATION_JSON_VALUE) | |||
| @Operation(summary = "get the network modifications infos contained in a composite modification") | |||
There was a problem hiding this comment.
get the network modifications infos related to the composite modification
or something else
"contained in a" is not correct
There was a problem hiding this comment.
I don't agree. I understand that in the database or java class they are related, but everything is related in that sense.
In the conceptual sense, though, a composite modification is a container of other network modifications, isn't it ? "Related" is true but I think this is too vague.
| @@ -249,6 +249,15 @@ public ResponseEntity<List<ElementAttributes>> getElementsMetadata(@RequestParam | |||
| return ResponseEntity.ok().contentType(MediaType.APPLICATION_JSON).body(directoryService.getElementsMetadata(ids, elementTypes, equipmentTypes)); | |||
| } | |||
|
|
|||
| @GetMapping(value = "/explore/composite-modification/{id}", produces = MediaType.APPLICATION_JSON_VALUE) | |||
| @Operation(summary = "get the network modifications infos contained in a composite modification") | |||
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Infos from all the contained network modifications")}) | |||
There was a problem hiding this comment.
the same for contained
| @@ -241,6 +241,10 @@ private IDirectoryElementsService getGenericService(String type) { | |||
| return iDirectoryElementsService; | |||
| } | |||
|
|
|||
| public List<Object> getCompositeModificationContent(UUID compositeModificationId) { | |||
| return ((NetworkModificationService) getGenericService(MODIFICATION)).getCompositeModificationContent(compositeModificationId); | |||
| } | |||
There was a problem hiding this comment.
why this function in directoryService ? it is not about cases
it should be in exploreservice
There was a problem hiding this comment.
True. I moved it.
|
Note in general: |
Indeed. I started with Metadata but decided to change because metadata is already used by the class I am going to remove all the references to metadata. I have not found any in this PR though. |
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
calls gridsuite/network-modification-server#541