-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First implementation #1
Conversation
f01c3bd
to
4a24073
Compare
7c893ae
to
eedf835
Compare
5db5af4
to
1323fed
Compare
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
1323fed
to
c47d4a7
Compare
src/main/java/org/gridsuite/filter/criteriafilter/AbstractEquipmentFilterForm.java
Outdated
Show resolved
Hide resolved
Files diff found with gridsuite/filter-server#101 (no content compare) --- gridsuite/filter-server 2024-03-15
+++ gridsuite/filter 2024-03-15
***************
- src/main/java/org/gridsuite/<...>/FiltersToGroovyScript.java
- src/main/resources/generator.st
- src/main/resources/hvdcLine.st
- src/main/resources/injection.st
- src/main/resources/line.st
- src/main/resources/substation.st
- src/main/resources/threeWindingsTransformer.st
- src/main/resources/twoWindingsTransformer.st
- src/main/resources/voltageLevel.st
- src/test/java/org/gridsuite/<...>/GenerateScriptFromFiltersTest.java
+ src/test/java/org/gridsuite/<...>/utils/FieldsMatcher.java
- src/test/java/org/gridsuite/<...>/utils/TestUtils.java Else for the two utility classes, the diff is mainly the scripting part that is deleted (not write in US). These files have been removed because, a long time ago, we have decided to remove the possibility to generate a script filter from other kinds of filters ... |
I think it's not a good approach with the FilterLoader is used to get a filter from an uuid, when evaluating, in an expert filter, a rule referencing the uuid of a filter linked to this expert filter (with 'is_part_of' and 'is_not_part_of' operators on 'ID' and 'VOLTAGE_ID' fields). |
Remove all Sonar warnings ! |
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good: I see you move all tests to JUnit5 😃
The is a rule of sonar on all @Test
methods:
Remove this 'public' modifier.
src/test/java/org/gridsuite/filter/utils/FieldsMatcherMetaTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/expertfilter/expertrule/CombinatorExpertRule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/expertfilter/expertrule/EnumExpertRule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/expertfilter/expertrule/FilterUuidExpertRule.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/filter/expertfilter/EnumExpertRuleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/filter/expertfilter/NumberExpertRuleTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
…class. Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
|
No description provided.