Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation #1

Merged
merged 5 commits into from
Mar 20, 2024
Merged

First implementation #1

merged 5 commits into from
Mar 20, 2024

Conversation

FranckLecuyer
Copy link
Collaborator

No description provided.

@FranckLecuyer FranckLecuyer changed the title First implementation [WIP] First implementation Mar 14, 2024
@FranckLecuyer FranckLecuyer force-pushed the first-impl branch 2 times, most recently from 7c893ae to eedf835 Compare March 15, 2024 10:49
@FranckLecuyer FranckLecuyer changed the title [WIP] First implementation First implementation Mar 15, 2024
@FranckLecuyer FranckLecuyer force-pushed the first-impl branch 2 times, most recently from 5db5af4 to 1323fed Compare March 15, 2024 12:55
Tristan-WorkGH

This comment was marked as duplicate.

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@Tristan-WorkGH
Copy link
Contributor

Tristan-WorkGH commented Mar 15, 2024

Files diff found with gridsuite/filter-server#101 (no content compare)

--- gridsuite/filter-server	2024-03-15
+++ gridsuite/filter	2024-03-15
***************
- src/main/java/org/gridsuite/<...>/FiltersToGroovyScript.java
- src/main/resources/generator.st
- src/main/resources/hvdcLine.st
- src/main/resources/injection.st
- src/main/resources/line.st
- src/main/resources/substation.st
- src/main/resources/threeWindingsTransformer.st
- src/main/resources/twoWindingsTransformer.st
- src/main/resources/voltageLevel.st
- src/test/java/org/gridsuite/<...>/GenerateScriptFromFiltersTest.java
+ src/test/java/org/gridsuite/<...>/utils/FieldsMatcher.java
- src/test/java/org/gridsuite/<...>/utils/TestUtils.java

Else for the two utility classes, the diff is mainly the scripting part that is deleted (not write in US).

These files have been removed because, a long time ago, we have decided to remove the possibility to generate a script filter from other kinds of filters ...

@SlimaneAmar SlimaneAmar self-requested a review March 18, 2024 11:58
@SlimaneAmar
Copy link
Contributor

SlimaneAmar commented Mar 18, 2024

I think it's not a good approach with the FilterLoader interface.
UUID is too specific to a repository
I think it's better to have a FilterEvaluator service and pass it a list of filters ?

FilterLoader is used to get a filter from an uuid, when evaluating, in an expert filter, a rule referencing the uuid of a filter linked to this expert filter (with 'is_part_of' and 'is_not_part_of' operators on 'ID' and 'VOLTAGE_ID' fields).
So, the input parameter is an uuid ...

@SlimaneAmar
Copy link
Contributor

Remove all Sonar warnings !

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good: I see you move all tests to JUnit5 😃
The is a rule of sonar on all @Test methods:

Remove this 'public' modifier.

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
…class.

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Copy link

@FranckLecuyer FranckLecuyer merged commit e5d5e22 into main Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants