Ask for confirmation before deleting users #31
Conversation
Signed-off-by: AAJELLAL <ali.ajellalod@gmail.com>
…o add_confirmation_before_deleting_users # Conflicts: # src/translations/en.json # src/translations/fr.json
Signed-off-by: AAJELLAL <ali.ajellalod@gmail.com>
src/pages/users/UsersPage.tsx
Outdated
| }, [gridContext, rowsSelection, snackError]); | ||
| const deleteUsersDisabled = useMemo( | ||
| () => rowsSelection.length <= 0, | ||
| [rowsSelection.length] | ||
| ); | ||
|
|
||
| const handleDeletion = (value: boolean) => { |
There was a problem hiding this comment.
you can directly call show(DeletionDialog) instead of handleDeletion. It would be more descriptive.
There was a problem hiding this comment.
I always prefer to use a separate method instead of calling the setXX directly. This way it's easy to maintain and we can add other verification as well if needed.
There was a problem hiding this comment.
yes, it makes sense too.
src/pages/users/UsersPage.tsx
Outdated
| <FormattedMessage id="ok" /> | ||
| </Button> | ||
| </DialogActions> | ||
| </Dialog> |
There was a problem hiding this comment.
UserPage was a big componant ... and is now more bigger.
We should split it in several part, like ProfilePages. Maybe not in this PR.
There was a problem hiding this comment.
Indeed the component is too big. However the file naming must be harmonized.
Example: UsersPage.tsx and profiles-page.tsx
There was a problem hiding this comment.
the global naming in GridSuite is more my-component.tsx rather than MyComponent.tsx
There was a problem hiding this comment.
ok, thanks for DeleteUserDialog
Signed-off-by: AAJELLAL <ali.ajellalod@gmail.com>
Signed-off-by: AAJELLAL <ali.ajellalod@gmail.com>
No description provided.