-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save NAD node movements in the reducer. #2275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prototype working for a multiple NADs, will break if VL change between nodes or if the NAD's VL's ID are ambiguous with another NAD instance Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
EstherDarkish
changed the title
WIP Save NAD node movements in the reducer.
Save NAD node movements in the reducer.
Sep 26, 2024
jamal-khey
reviewed
Sep 27, 2024
Quality Gate passedIssues Measures |
jamal-khey
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code Ok
Tests Ok
jamal-khey
added a commit
that referenced
this pull request
Sep 27, 2024
This reverts commit 88de30d.
EstherDarkish
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using powsybl/powsybl-network-viewer#101