Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save NAD node movements in the reducer. #2275

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Conversation

EstherDarkish
Copy link
Contributor

@EstherDarkish EstherDarkish commented Sep 25, 2024

BOUTIER Charly added 4 commits September 26, 2024 01:43
Prototype working for a multiple NADs, will break if VL change between nodes or if the NAD's VL's ID are ambiguous with another NAD instance

Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish EstherDarkish changed the title WIP Save NAD node movements in the reducer. Save NAD node movements in the reducer. Sep 26, 2024
BOUTIER Charly and others added 2 commits September 26, 2024 23:07
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
src/redux/reducer.ts Outdated Show resolved Hide resolved
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Copy link

Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code Ok
Tests Ok

@EstherDarkish EstherDarkish merged commit 88de30d into main Sep 27, 2024
4 checks passed
@EstherDarkish EstherDarkish deleted the NAD_save_node_movements branch September 27, 2024 11:45
jamal-khey added a commit that referenced this pull request Sep 27, 2024
EstherDarkish added a commit that referenced this pull request Sep 27, 2024
This reverts commit 88de30d.

Co-authored-by: jamal-khey <myjamal89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants