-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : create new spreadsheet #2340
Conversation
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
4bb2055
to
c49a24e
Compare
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
26fdee4
to
f00ac1f
Compare
…eadsheets Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
f00ac1f
to
a865c57
Compare
src/components/spreadsheet/add-new-spreadsheet/add-new-spreadsheet-dialog.tsx
Outdated
Show resolved
Hide resolved
src/components/spreadsheet/add-new-spreadsheet/add-new-spreadsheet-dialog.tsx
Outdated
Show resolved
Hide resolved
src/components/spreadsheet/add-new-spreadsheet/add-new-spreadsheet-dialog.tsx
Outdated
Show resolved
Hide resolved
src/components/spreadsheet/add-new-spreadsheet/add-new-spreadsheet-dialog.tsx
Outdated
Show resolved
Hide resolved
src/components/spreadsheet/add-new-spreadsheet/add-new-spreadsheet-dialog.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests:
After adding a new empty spreadsheet, nothing is displayed when we select this new spreadsheet (only 'Loading...' is shown) : we have to select first another existing spreadsheet and then to select this newly created spreadsheet in order to see the data (for the predefined fixed columns selected by default).
No error is shown when adding a new spreadsheet from a template seen in the directory tree, but that no longer exists ...
After adding a new spreadsheet named 'titi', error messages are shown in the console :
Error: [@formatjs/intl Error MISSING_TRANSLATION] Missing message: "titi" for locale "en", using id as fallback.
After adding a new spreadsheet from template, all the columns are custom columns (ok), but the 'Show / id columns' button displays an empty column list ...maybe this button should be disabled ...
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
91a41d1
to
d4671c1
Compare
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
d4671c1
to
fcc22e9
Compare
Quality Gate passedIssues Measures |
No description provided.