Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : create new spreadsheet #2340

Merged
merged 9 commits into from
Oct 23, 2024
Merged

Conversation

ayolab
Copy link
Contributor

@ayolab ayolab commented Oct 22, 2024

No description provided.

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab changed the title Ayolab/feat create new spreadsheet Feat : create new spreadsheet Oct 22, 2024
@ayolab ayolab force-pushed the ayolab/feat-create-new-spreadsheet branch 2 times, most recently from 4bb2055 to c49a24e Compare October 22, 2024 07:01
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab force-pushed the ayolab/feat-create-new-spreadsheet branch 2 times, most recently from 26fdee4 to f00ac1f Compare October 22, 2024 11:15
…eadsheets

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab force-pushed the ayolab/feat-create-new-spreadsheet branch from f00ac1f to a865c57 Compare October 22, 2024 11:23
src/redux/actions.ts Outdated Show resolved Hide resolved
src/redux/actions.ts Outdated Show resolved Hide resolved
ayolab and others added 3 commits October 22, 2024 17:00
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Copy link
Contributor

@FranckLecuyer FranckLecuyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests:
After adding a new empty spreadsheet, nothing is displayed when we select this new spreadsheet (only 'Loading...' is shown) : we have to select first another existing spreadsheet and then to select this newly created spreadsheet in order to see the data (for the predefined fixed columns selected by default).

No error is shown when adding a new spreadsheet from a template seen in the directory tree, but that no longer exists ...

After adding a new spreadsheet named 'titi', error messages are shown in the console :
Error: [@formatjs/intl Error MISSING_TRANSLATION] Missing message: "titi" for locale "en", using id as fallback.

After adding a new spreadsheet from template, all the columns are custom columns (ok), but the 'Show / id columns' button displays an empty column list ...maybe this button should be disabled ...

src/translations/spreadsheet-fr.ts Outdated Show resolved Hide resolved
src/components/app.jsx Outdated Show resolved Hide resolved
src/components/app.jsx Outdated Show resolved Hide resolved
src/components/app.jsx Outdated Show resolved Hide resolved
src/components/app.jsx Outdated Show resolved Hide resolved
src/components/app.jsx Outdated Show resolved Hide resolved
src/components/app.jsx Outdated Show resolved Hide resolved
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab force-pushed the ayolab/feat-create-new-spreadsheet branch 3 times, most recently from 91a41d1 to d4671c1 Compare October 23, 2024 11:35
@ayolab ayolab changed the base branch from main to ayolab/remove-custom-columns-cross-referencing October 23, 2024 11:36
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
@ayolab ayolab force-pushed the ayolab/feat-create-new-spreadsheet branch from d4671c1 to fcc22e9 Compare October 23, 2024 11:47
Base automatically changed from ayolab/remove-custom-columns-cross-referencing to main October 23, 2024 13:47
Copy link

sonarcloud bot commented Oct 23, 2024

@ayolab ayolab merged commit 84dc609 into main Oct 23, 2024
4 checks passed
@ayolab ayolab deleted the ayolab/feat-create-new-spreadsheet branch October 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants