Refactor config notifications management with NotificationsProvider #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sProvider from commons-ui Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
…otificationsListener Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
…possible, update url later. This allow listeners to be registered even if websocket url is not ready Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
TheMaskedTurtle
approved these changes
Dec 17, 2024
…t build the urlMapper Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
sBouzols
force-pushed
the
refactor_replace_config_websocket_provider
branch
from
80d624f to
b825f7c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see NotificationsProvider from commons-ui