gather all the unit conversions into one file #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 686 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 639 | 1 | 46 | 0 |
Click to see the invalid file list
- src/components/dialogs/converter-unit-utils.ts
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
ghazwarhili
commented
Dec 17, 2024
...nents/dialogs/network-modifications/voltage-level/creation/voltage-level-creation-dialog.jsx
Outdated
Show resolved
Hide resolved
ghazwarhili
commented
Dec 17, 2024
...alogs/network-modifications/voltage-level/modification/voltage-level-modification-dialog.jsx
Outdated
Show resolved
Hide resolved
ghazwarhili
commented
Dec 17, 2024
src/components/results/shortcircuit/shortcircuit-analysis-result-content.ts
Outdated
Show resolved
Hide resolved
src/components/results/shortcircuit/shortcircuit-analysis-result-table.tsx
Outdated
Show resolved
Hide resolved
src/components/results/shortcircuit/shortcircuit-analysis-result-table.tsx
Outdated
Show resolved
Hide resolved
src/components/results/shortcircuit/shortcircuit-analysis-result-table.tsx
Outdated
Show resolved
Hide resolved
src/components/results/shortcircuit/shortcircuit-analysis-result-table.tsx
Outdated
Show resolved
Hide resolved
src/components/results/shortcircuit/shortcircuit-analysis-result-table.tsx
Outdated
Show resolved
Hide resolved
…ne-file' into mutualize-unit-conversion-into-one-file
…ne-file' into mutualize-unit-conversion-into-one-file
ghazwarhili
commented
Dec 18, 2024
...nents/dialogs/network-modifications/voltage-level/creation/voltage-level-creation-dialog.jsx
Outdated
Show resolved
Hide resolved
...nents/dialogs/network-modifications/voltage-level/creation/voltage-level-creation-dialog.jsx
Outdated
Show resolved
Hide resolved
...nents/dialogs/network-modifications/voltage-level/creation/voltage-level-creation-dialog.jsx
Outdated
Show resolved
Hide resolved
...nents/dialogs/network-modifications/voltage-level/creation/voltage-level-creation-dialog.jsx
Outdated
Show resolved
Hide resolved
...alogs/network-modifications/voltage-level/modification/voltage-level-modification-dialog.jsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
thangqp
reviewed
Dec 20, 2024
| case B2: | ||
| return unitToMicroUnit(value?.value); | ||
| return convertInputValues(FieldType.B2, value?.value); |
There was a problem hiding this comment.
what's about MAX_SUSCEPTANCE, in IHM is S and IIDM is MicroS ?
Also, the csv file the value edited for MAX_SUSCEPTANCE is in S or MicroS ?
There was a problem hiding this comment.
It is planned to handle the fix for labels for all the IHM of gridstudy in another PR (we have already another US to fix this)
| case B2: | ||
| return toModificationOperation(microUnitToUnit(value)); | ||
| return toModificationOperation(convertOutputValues(FieldType.B2, value)); |
There was a problem hiding this comment.
idem, what's about MAX_SUSCEPTANCE, in IHM is S and IIDM is MicroS?
| MAXIMUM_SUSCEPTANCE: { | ||
| id: FieldType.MAXIMUM_SUSCEPTANCE, | ||
| MAX_SUSCEPTANCE: { | ||
| id: FieldType.MAX_SUSCEPTANCE, | ||
| label: 'maxSusceptance', | ||
| unit: MICRO_SIEMENS, |
| MAXIMUM_Q_AT_NOMINAL_VOLTAGE: { | ||
| id: FieldType.MAXIMUM_Q_AT_NOMINAL_VOLTAGE, | ||
| MAX_Q_AT_NOMINAL_V: { | ||
| id: FieldType.MAX_Q_AT_NOMINAL_V, | ||
| label: 'maxQAtNominalV', | ||
| unit: MICRO_SIEMENS, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.