Add report mode handling in report service and related classes #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: achour94 <berrahmaachour@gmail.com>
Signed-off-by: achour94 <berrahmaachour@gmail.com>
…cation-report-when-building-variant # Conflicts: # src/test/java/org/gridsuite/modification/server/service/BuildTest.java
|
dbraquart
reviewed
Nov 24, 2025
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: 1 remark
tests: in progress
Comment on lines
+67
to
+68
| String endpoint = reportMode == ReportMode.REPLACE ? "replace" : ""; | ||
| var path = UriComponentsBuilder.fromPath("{reportUuid}" + (endpoint.isEmpty() ? "" : "/" + endpoint)) |
Contributor
There was a problem hiding this comment.
Suggested change
| String endpoint = reportMode == ReportMode.REPLACE ? "replace" : ""; | |
| var path = UriComponentsBuilder.fromPath("{reportUuid}" + (endpoint.isEmpty() ? "" : "/" + endpoint)) | |
| var path = UriComponentsBuilder.fromPath("{reportUuid}{endpoint}") |
| public void sendReport(UUID reportUuid, ReportNode reportNode, ReportMode reportMode) { | ||
| String endpoint = reportMode == ReportMode.REPLACE ? "replace" : ""; | ||
| var path = UriComponentsBuilder.fromPath("{reportUuid}" + (endpoint.isEmpty() ? "" : "/" + endpoint)) | ||
| .buildAndExpand(reportUuid) |
Contributor
There was a problem hiding this comment.
Suggested change
| .buildAndExpand(reportUuid) | |
| .buildAndExpand(reportUuid, reportMode == ReportMode.REPLACE ? "/replace" : "") |
simplier ? and maybe will remove the Sonar issue ?
Contributor
TheMaskedTurtle
left a comment
TheMaskedTurtle
left a comment
There was a problem hiding this comment.
Same remark as David otherwise it is fine for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces support for a new
ReportModeoption in the reporting workflow, allowing reports to be either appended to or replaced. The changes involve updating the DTOs, service methods, and relevant tests to handle this new mode, while maintaining backward compatibility by defaulting to the append behavior.Feature: Report mode support
ReportModeenum (APPEND,REPLACE) inorg.gridsuite.modification.server.dtoto specify how reports are handled.ReportInfosDTO to include areportModefield, a no-argument constructor, and a constructor that defaultsreportModetoAPPEND.Service changes
ReportService.sendReportmethod to accept aReportModeparameter, determining the endpoint used for report submission (replaceforREPLACE, default forAPPEND). Overloaded the method to maintain backward compatibility.NetworkModificationApplicatorto pass thereportModefromReportInfoswhen sending reports.