-
Notifications
You must be signed in to change notification settings - Fork 0
generalize services classes #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…text Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
@SlimaneAmar @thangqp Your requests had a lot in common so I combined them into one commit. I tested a few run and cancels and it all runs like before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note : In common classes, there are several files which have some formats different to ones in loadflow but it is not important since we move only common files in loadflow server into a common repo
Code OK, Test OK (including 'stop a running')
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
|



Refactorization in order to simplify code sharing between computation microservices, especially in the 'service' package.
The code in the new 'computation' package should be copyable to all the other computation microservices and extended there.
It was created in a first PR in the load flow service, this PR is only an adaptation of the common classes to security analysis, but it will include some modifications.
Changes (that were in the loadflow version of the code, and therefore are now in the common code used bu security analysis) :
// Today we don't send notification inside @transactional block. If this behavior change, we should use @PostCompletion to
// make sure that the notification is sent only when all the work inside @transactional block is done.
=> it seems that now notification are indeed sent inside @transactional blocs so it should be fine (===> should be verified and tested) => checks with Anis Touri