feat: rely on rabbitmq dlq for computation errors handling #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
feat/rabbit-dlq-on-fail
branch
from
714225b to
9559167
Compare
jonenst
approved these changes
Dec 17, 2024
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
antoinebhs
approved these changes
Dec 18, 2024
pom.xml
Outdated
| @@ -86,6 +86,11 @@ | |||
| <dependencyManagement> | |||
| <dependencies> | |||
| <!-- overrides of imports --> | |||
| <dependency> | |||
There was a problem hiding this comment.
to remove next powsybl upgrade?
There was a problem hiding this comment.
I will update with the released version of powsybl-ws-commons anyway, so I will ad the comment
antoinebhs
reviewed
Dec 18, 2024
| assertEquals("me", cancelMessage.getHeaders().get("receiver")); | ||
| assertEquals(getFailedMessage(COMPUTATION_TYPE) + " : " + ERROR_MESSAGE, cancelMessage.getHeaders().get("message")); | ||
| // No result message | ||
| assertNull(output.receive(TIMEOUT, "sa.result")); |
There was a problem hiding this comment.
I think the equivalent test is to check if there is a .ComputationException with the corresponding message?
There was a problem hiding this comment.
can we check the run.dlx?
There was a problem hiding this comment.
no sadly it doesn't work... the default test binder setup by springcloudstream doesn't behave the same, then I couldn't test like that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.