-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic rounding of results for comparisons #118
Conversation
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
…o dynamic-rounding-on-results
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Quality Gate passedIssues Measures |
@@ -338,7 +338,7 @@ private Stream<Arguments> provideNotEqualFilters() { | |||
resultMagnitudeEntity, | |||
List.of( | |||
new ResourceFilter(ResourceFilter.DataType.NUMBER, ResourceFilter.Type.NOT_EQUAL, 47, "current")), | |||
List.of(faultResultEntity1, faultResultEntity2, faultResultEntity3)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it removed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the NOT_EQUAL criteria changed. It used to have a 0.00001 tolerance. Now it computes a tolerance relative to the number of decimal after the dot.
According to this criteria, faultResultEntity2 is now equal to resultMagnitudeEntity.
No description provided.