Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic rounding of results for comparisons #118

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

Mathieu-Deharbe
Copy link
Contributor

No description provided.

Mathieu-Deharbe and others added 6 commits October 28, 2024 15:45
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
…o dynamic-rounding-on-results
Mathieu-Deharbe and others added 3 commits November 15, 2024 10:53
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@@ -338,7 +338,7 @@ private Stream<Arguments> provideNotEqualFilters() {
resultMagnitudeEntity,
List.of(
new ResourceFilter(ResourceFilter.DataType.NUMBER, ResourceFilter.Type.NOT_EQUAL, 47, "current")),
List.of(faultResultEntity1, faultResultEntity2, faultResultEntity3)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it removed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the NOT_EQUAL criteria changed. It used to have a 0.00001 tolerance. Now it computes a tolerance relative to the number of decimal after the dot.
According to this criteria, faultResultEntity2 is now equal to resultMagnitudeEntity.

@Mathieu-Deharbe Mathieu-Deharbe merged commit 33ad3dd into main Nov 26, 2024
3 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the dynamic-rounding-on-results branch November 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants