springboot 3.1.2 #27
Merged
springboot 3.1.2 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
jonenst
reviewed
Aug 22, 2023
| @@ -461,7 +461,6 @@ public void stopTest() throws Exception { | |||
| assertNotNull(output.receive(TIMEOUT, shortCircuitAnalysisRunDestination)); | |||
| mockMvc.perform(put("/" + VERSION + "/results/{resultUuid}/stop" + "?receiver=me", RESULT_UUID_TO_STOP)) | |||
| .andExpect(status().isOk()); | |||
| assertNotNull(output.receive(TIMEOUT, shortCircuitAnalysisCancelDestination)); | |||
There was a problem hiding this comment.
I think we need to find another workaround (see comment line 446) or fix this correctly
There was a problem hiding this comment.
Problem is the consumed message are no longer available on the queue so checking the output doesn't cut it anymore. I don't understand how this relates to the comment you mentioned. This problem happened with all the tests containing checks on consumed messages.
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
…:git-commit-id-maven-plugin Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
…or spring cloud stream 4+ compatibility when the object is null It works with 3.2.4 but with 4.0.3 i'm getting java.lang.ClassCastException: class [B cannot be cast to class java.lang.String For spring cloud stream 4 vs spring cloud stream 3, in both cases, our string is converted to a byte[] with content-type application/json, but for 3.2.4 the byte[] gets converted back to the original string, whereas with 4.0.3 it gets converted to the parsed json object. -> "null" -> [110, 117, 108, 108] (spring cloud to byte[]) -> null # instead of "null" With 3.2.4 the byte[] gets converted to string here: https://github.com/spring-cloud/spring-cloud-stream/blob/6bc8330dcbdee52e44266cbf0f0043cf4fc3c0d4/core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/converter/ApplicationJsonMessageMarshallingConverter.java#L109 With 4.0.3 it uses spring cloud function org.springframework.cloud.function.context.config.SmartCompositeMessageConverter which uses jackson readValue on the string. With 4.0.3 if I send a non null object, I get the previous behavior (because of an intermediate try/catch in spring cloud stream which falls back to restoring the string, I guess not very good for performance and design?): "com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type java.lang.String from Object value (token JsonToken.START_OBJECT)" https://github.com/spring-cloud/spring-cloud-function/blob/cc740db82e27efee4e23af4ad8e1de6f6a6fc9e9/spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/config/JsonMessageConverter.java#L98
the getFeederResults and getLimitViolations were empty, but now they have [null, null, null] ??
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
jonenst
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.