Make filtering case insensitive and restrict the limit violation enum values. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
YenguiSeddik
reviewed
Nov 3, 2023
| } | ||
|
|
||
| public static <X> Specification<X> contains(String field, String value) { | ||
| return (root, cq, cb) -> cb.like(getColumnPath(root, field), "%" + EscapeCharacter.DEFAULT.escape(value) + "%", EscapeCharacter.DEFAULT.getEscapeCharacter()); | ||
| return (root, cq, cb) -> cb.like(cb.upper(getColumnPath(root, field)), "%" + EscapeCharacter.DEFAULT.escape(value).toUpperCase() + "%", EscapeCharacter.DEFAULT.getEscapeCharacter()); |
There was a problem hiding this comment.
The value can't be null?
intellij suggest to add : Objects.requireNonNull(EscapeCharacter.DEFAULT.escape(value)).toUpperCase()
There was a problem hiding this comment.
If value of filter is null it will broke before during the toString().
I didn't manage it but maybe I should use NonNull on every params of the record ?
There was a problem hiding this comment.
Actually I use null in some cases (for EQUALS by instance, but I will probably change it later).
I add it in my TODO list to check when I'll come back.
sBouzols
approved these changes
Nov 3, 2023
EtienneLt
pushed a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.