Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove previous courcirc logs when run starts #53

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

dbraquart
Copy link
Contributor

No description provided.

Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
@dbraquart dbraquart changed the title WIP Separate computation logs from modification logs remove previous courcirc logs when run starts Nov 17, 2023
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
@EstherDarkish EstherDarkish self-requested a review November 21, 2023 08:56
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
@@ -59,11 +59,12 @@ public ResponseEntity<UUID> runAndSave(@Parameter(description = "Network UUID")
@Parameter(description = "Result receiver") @RequestParam(name = "receiver", required = false) String receiver,
@Parameter(description = "reportUuid") @RequestParam(name = "reportUuid", required = false) UUID reportUuid,
@Parameter(description = "reporterId") @RequestParam(name = "reporterId", required = false) String reporterId,
@Parameter(description = "The type name for the report") @RequestParam(name = "reportType", required = false) String reportType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add defaultValue

Copy link
Contributor Author

@dbraquart dbraquart Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant put a default value here: I dont know if it's AllBuses or OneBus case.
So I made it in the workerService

…logs

# Conflicts:
#	src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitRunContext.java
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.8% 84.8% Coverage
0.0% 0.0% Duplication

@dbraquart dbraquart merged commit c32010b into main Nov 23, 2023
4 checks passed
@dbraquart dbraquart deleted the separate_computation_logs_from_modification_logs branch November 23, 2023 11:46
EtienneLt pushed a commit that referenced this pull request Jul 2, 2024
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants