Implement basic operations #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMaskedTurtle
requested changes
Sep 30, 2024
src/main/java/org/gridsuite/spreadsheetconfig/server/RestResponseEntityExceptionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/RestTemplateConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/SwaggerConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/mapper/SpreadsheetConfigMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/repositories/CustomColumnRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/entities/CustomColumnEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/service/SpreadsheetConfigService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/service/SpreadsheetConfigService.java
Outdated
Show resolved
Hide resolved
FranckLecuyer
requested changes
Sep 30, 2024
pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>io.micrometer</groupId> | ||
| <artifactId>micrometer-registry-prometheus</artifactId> |
src/test/resources/logback-test.xml
Outdated
| <!-- | ||
| our logs | ||
| --> | ||
| <logger name="org.gridsuite.useradmin.server" level="trace"/> |
There was a problem hiding this comment.
org.gridsuite.spreadsheetconfig.server
| @Column(name = "name", nullable = false, columnDefinition = "varchar(255)") | ||
| private String name; | ||
|
|
||
| @Column(name = "formula", columnDefinition = "varchar(255)") |
There was a problem hiding this comment.
Use CLOB for the formula column type
FranckLecuyer
requested changes
Sep 30, 2024
| @Enumerated(EnumType.STRING) | ||
| private SheetType sheetType; | ||
|
|
||
| @OneToMany(mappedBy = "spreadsheetConfig", cascade = CascadeType.ALL, orphanRemoval = true) |
There was a problem hiding this comment.
Why not using here the annotations ElementCollection and CollectionTable
and the Embeddable annotation in CustomColumnEntity (and removing the ManyToOne relationship with SpreadsheetConfigEntity in CustomColumnEntity)
AbdelHedhili
requested changes
Sep 30, 2024
src/main/java/org/gridsuite/spreadsheetconfig/server/dto/CustomColumnDto.java
Outdated
Show resolved
Hide resolved
...main/java/org/gridsuite/spreadsheetconfig/server/controller/SpreadsheetConfigController.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/spreadsheetconfig/server/dto/SpreadsheetConfigDto.java
Outdated
Show resolved
Hide resolved
Signed-off-by: achour94 <berrahmaachour@gmail.com>
achour94
requested review from
FranckLecuyer,
TheMaskedTurtle and
AbdelHedhili
Signed-off-by: achour94 <berrahmaachour@gmail.com>
AbdelHedhili
approved these changes
Oct 1, 2024
FranckLecuyer
approved these changes
Oct 1, 2024
TheMaskedTurtle
requested changes
Oct 1, 2024
src/test/java/org/gridsuite/spreadsheetconfig/server/SpreadsheetConfigControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/spreadsheetconfig/server/SpreadsheetConfigControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/spreadsheetconfig/server/SpreadsheetConfigControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/spreadsheetconfig/server/SpreadsheetConfigControllerTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Schema(description = "Column formula") | ||
| String formula | ||
| ) { } |
There was a problem hiding this comment.
It miss the type of data (string, interger, boolean, ...) for aggrid in front know of to parse the result of formula. If null, stick to default behaviour: aggrid auto/try to guess the type.
Suggested change
| ) { } | |
| @Schema(description = "Column type") | |
| ColumnType type; | |
| ) { } |
There was a problem hiding this comment.
How can we get this information !?
Signed-off-by: achour94 <berrahmaachour@gmail.com>
|
TheMaskedTurtle
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.