Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sheet type values and use OrderColumn #5

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Change sheet type values and use OrderColumn #5

merged 3 commits into from
Oct 18, 2024

Conversation

dbraquart
Copy link
Contributor

No description provided.

@TheMaskedTurtle TheMaskedTurtle force-pushed the main branch 5 times, most recently from 3a194d0 to d2b12d0 Compare October 16, 2024 14:58
@dbraquart dbraquart force-pushed the change-sheet-type-values branch from c25b98a to 7f37d1d Compare October 16, 2024 18:16
achour94
achour94 reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@achour94 achour94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the ordering (getting the results in the same order that we saved it )

@dbraquart
Copy link
Contributor Author

Can you add a test for the ordering (getting the results in the same order that we saved it )

We already have a test (cf testCreate) that compares excatly retrieved data vs inserted data. In fact I could not see the issue while testing with h2. I see the issue only when I run the app with Posgres.

@dbraquart dbraquart requested a review from achour94 October 17, 2024 14:43
@dbraquart
rev remarks (use only generated liquibase change sets)
701a0c6 
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
@dbraquart dbraquart force-pushed the change-sheet-type-values branch from eae1fd6 to 701a0c6 Compare October 18, 2024 12:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbraquart dbraquart requested a review from achour94 October 18, 2024 13:28
@dbraquart dbraquart merged commit feadb3d into main Oct 18, 2024
3 checks passed
TheMaskedTurtle pushed a commit that referenced this pull request Oct 22, 2024
@dbraquart @TheMaskedTurtle
Change sheet type values and use OrderColumn (#5)
6c675b6 
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achour94 achour94 achour94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbraquart @achour94