Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log the cancellation exception #31

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

antoinebhs
Copy link
Contributor

@antoinebhs antoinebhs commented Dec 5, 2023

Get a consistent implementation with respect to other calculation services, log a cancellation message instead.

antoinebhs and others added 2 commits December 5, 2023 14:17
Get a consistent implementation with respect to other calculation services.
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@antoinebhs antoinebhs changed the title Don't log the cancellation exception. Don't log the cancellation exception Dec 5, 2023
@Meklo Meklo self-requested a review December 5, 2023 14:29
@antoinebhs antoinebhs merged commit d577cf7 into main Dec 5, 2023
4 checks passed
@Tristan-WorkGH Tristan-WorkGH deleted the log-cancellation-exception branch April 3, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants