Upgrade rules_jvm_external from 4.5 to 5.3 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcompton
commented
Nov 1, 2023
| sha256 = RULES_JVM_EXTERNAL_SHA, | ||
| strip_prefix = "rules_jvm_external-%s" % RULES_JVM_EXTERNAL_TAG, | ||
| url = "https://github.com/bazelbuild/rules_jvm_external/archive/%s.zip" % RULES_JVM_EXTERNAL_TAG, | ||
| url = "https://github.com/bazelbuild/rules_jvm_external/releases/download/%s/rules_jvm_external-%s.tar.gz" % (RULES_JVM_EXTERNAL_TAG, RULES_JVM_EXTERNAL_TAG), |
Contributor
Author
There was a problem hiding this comment.
I changed this to match the suggested install instructions in https://github.com/bazelbuild/rules_jvm_external/releases/tag/5.3.
This repins the dependencies due to the lockfile changing: https://github.com/bazelbuild/rules_jvm_external/releases/tag/5.0
danielcompton
force-pushed
the
dc/upgrade-rules_java-540
branch
from
17585e6 to
d78a09e
Compare
Contributor
Author
|
@english is there any interest in this PR? I can update it to v6.6 if that is helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repins the dependencies due to the lockfile changing: https://github.com/bazelbuild/rules_jvm_external/releases/tag/5.0