Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nan values in the Mutation Position column #1079

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

susannasiebert
Copy link
Contributor

A recent update to the aggregate report creation parses "NA" values as pandas nan instead of a string. This update failed to address the is_anchor_residue_pass logic, which still assumed that this column was parsed as a string which is fixed by this PR.

Closes #1074

@susannasiebert susannasiebert linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link
Member

@acoffman acoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert merged commit ae1f135 into hotfix Mar 13, 2024
5 of 6 checks passed
@susannasiebert susannasiebert deleted the issue_1074 branch June 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: argument of type 'float' is not iterable
2 participants