Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new valid_algorithms command (#1106) #1108

Merged
merged 11 commits into from
Jun 5, 2024
Merged

Added new valid_algorithms command (#1106) #1108

merged 11 commits into from
Jun 5, 2024

Conversation

ldhtnp
Copy link
Contributor

@ldhtnp ldhtnp commented Jun 4, 2024

Completed issue#1106 and all tests are passing on my end

@ldhtnp ldhtnp changed the title Issues/1106 Added new valid_algorithms command (#1106) Jun 4, 2024
susannasiebert
susannasiebert requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I made a few minor change suggestion.

docs/pvacbind/additional_commands.rst Outdated Show resolved Hide resolved
docs/pvacfuse/additional_commands.rst Outdated Show resolved Hide resolved
docs/pvacseq/additional_commands.rst Outdated Show resolved Hide resolved
docs/pvacvector/additional_commands.rst Outdated Show resolved Hide resolved
pvactools/lib/valid_algorithms.py Outdated Show resolved Hide resolved
pvactools/lib/valid_algorithms.py Outdated Show resolved Hide resolved
pvactools/lib/valid_algorithms.py Outdated Show resolved Hide resolved
@ldhtnp @susannasiebert
applied suggestions from the PR review
cb2d395 
Co-authored-by: Susanna Kiwala <susanna.kiwala@wustl.edu>
susannasiebert
susannasiebert approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert merged commit 7bc69d1 into griffithlab:staging Jun 5, 2024
5 of 6 checks passed
@susannasiebert susannasiebert linked an issue Jun 12, 2024 that may be closed by this pull request
Implement new command pvacseq valid_algorithms to see which prediction algorithms support a specific allele and/or species #1106
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susannasiebert susannasiebert susannasiebert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ldhtnp @susannasiebert