Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ifx (intel-llvm) when determining compiler settings #1060

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

TyBalduf
Copy link
Contributor

  • Use fc_id throughout meson.build, rather than repeatedly calling fc.get_id().
  • Wherever we previously branched for "intel" (ifort compiler), also branch for "intel-llvm" (ifx compiler).

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks good to me

* Use `fc_id` throughout meson.build, rather than repeatedly calling `fc.get_id()`.
* Wherever we previously branched for `"intel"` (ifort compiler), also branch for `"intel-llvm"` (ifx compiler).

Signed-off-by: Ty Balduf <ty.balduf@schrodinger.com>
@marcelmbn marcelmbn merged commit e280465 into grimme-lab:main Aug 9, 2024
11 checks passed
@TyBalduf TyBalduf deleted the patch-1 branch August 9, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants