Add dependecies in meson build #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorges97
pushed a commit
to gorges97/xtb
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
|
@Thomas3R @Albkat If these are not required, it would be useful to have an option similar to cpx/tblite to enable/disable them. I noticed a build failure locally on my Windows machine (intel-cl 2021.5.0 Fortran/(msvc 19.29.30141 C compilers, using meson) while linking multicharge related libraries. I could probably patch around, but if they really are optional, I could put together a pull request to make them optional. EDIT: Was able to compile locally with these dependencies disable and all tests ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.