Custom spherical radius & SpatialTrait annotations #117
+171
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @khooz ! I've been working on adding SRID support in the Also: |
|
Can I change the base of this PR and work on it? |
|
Also, feel free to test the |
|
Sure. Sorry for the late response. I will test that branch too, though applications may be limited since most of the time, sticking to one SRID (no matter which) will give you a fair result in cases such as distance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is adding a parameter for spherical functions for radius, annotates SpatialTrait with PHPDoc blocks, and defaults the earth radius to a more accurate median (down to cm).
It references #91 and #114; it also fails at CI since the more accurate default radius and the nature of new functionality, which I hope can be resolved.