Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eloquent builder methods instead of scopes #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MatanYadaev
Copy link
Contributor

This PR moves the whole scopes to a dedicated builder (which already exists).

This approach presented introduced in the "Dedicated query builders for Eloquent models" blogpost.

@grimzy What do you think about this approach? Do you notice any drawbacks?

Personally, in my own company, we're using only dedicated model builders and there's a lot of benefit from it.
I thought it could be great to have real IDE autocomplete for spatial methods:

namespace App\Builders;

use Grimzy\LaravelMysqlSpatial\Eloquent\Builder as SpatialBuilder;
use Grimzy\LaravelMysqlSpatial\Types\Point;

class UserBuilder extends SpatialBuilder
{
    public function inRange(Point $point, int $radius)
    {
        $this->distanceSphereValue('location', $point)->having('distance', '<', $radius);

        return $this;
    }
}

@MatanYadaev MatanYadaev changed the title Use builder methods instead of scopes Use Eloquent builder methods instead of scopes Nov 5, 2020
@MatanYadaev
Copy link
Contributor Author

@grimzy WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant