Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining clang instantiation warnings. #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Dec 9, 2017

  1. Fix remaining clang instantiation warnings.

    These warnings were specific to the static data members of the class
    and looked like the following:
    
    ../../src/boundary_conditions/include/grins/dirichlet_bc_factory_function_old_style_base.h:88:16: warning:
    instantiation of variable 'GRINS::DirichletBCFactoryFunctionOldStyleBase<libMesh::FunctionBase<double> >::_var_names_old_style' required here, but no definition is
    available [-Wundefined-var-template]
        if( !this->_var_names_old_style )
                   ^
    ../../src/boundary_conditions/include/grins/prescribed_vector_value_dirichlet_old_style_bc_factory.h:40:5: note:
    in instantiation of member function 'GRINS::DirichletBCFactoryFunctionOldStyleBase<libMesh::FunctionBase<double> >::check_state' requested here
        PrescribedVectorValueDirichletOldStyleBCFactory( const std::string& bc_type_name )
        ^
    ../../src/boundary_conditions/include/grins/dirichlet_bc_factory_function_old_style_base.h:72:44:
    note: forward declaration of template entity is here
        static const std::vector<std::string>* _var_names_old_style;
                                               ^
    ../../src/boundary_conditions/include/grins/dirichlet_bc_factory_function_old_style_base.h:88:16:
    note: add an explicit instantiation declaration to suppress this warning if 'GRINS::DirichletBCFactoryFunctionOldStyleBase<libMesh::FunctionBase<double> >::_var_names_old_style'
          is explicitly instantiated in another translation unit
        if( !this->_var_names_old_style )
                   ^
    jwpeterson committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    d775d1f View commit details
    Browse the repository at this point in the history