Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanup of code for Python before 3.8, fix astroid import #156

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Nov 24, 2024

In preparation for a release I noticed quite a bit of code remaining specifically for old Python versions, as well as an unprotected astroid import which would have been a disaster.

View with whitespace changes hidden because big blocks have been unindented: https://github.com/gristlabs/asttokens/pull/156/files?w=1

@alexmojaki alexmojaki marked this pull request as draft November 24, 2024 13:15
@alexmojaki alexmojaki marked this pull request as ready for review November 24, 2024 13:41
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense. Thank you!

@alexmojaki
Copy link
Contributor Author

Thanks! Please can you take care of the release?

@alexmojaki alexmojaki merged commit 89f02d2 into master Nov 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants