Add IdP timeout, remaining backward compatible #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for responding so late, I am on holidays as the moment. I have added a comment, I do need re-approval please. |
fflorent
approved these changes
Jul 7, 2024
|
Hello @atropos112! I see that you have closed the issue. Could you share with us the reason? |
|
I was cleaning my forked repos, didnt see any response here so assumed its stale. The change is no longer vital to my use case either. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I have attempted to use Authelia with OpenID storing pbkdf2 hash in values.yaml for authelia's helm chart and then storing the secret for grist. To do this comparison Authelia can take few seconds often surpassing the 3500ms timeout window that is the default value as described here. I didn't see an env variable I could adjust this timeout with so this is the PR of me attempting to add it.
Please do note, I don't know typescript/javascript at all, the code i wrote "looks ok" to me but please do double check.