Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix table in card #1

Merged
merged 1 commit into from
Feb 25, 2019
Merged

fix table in card #1

merged 1 commit into from
Feb 25, 2019

Conversation

adrian-bobev
Copy link
Contributor

This PR corrects slot names for the table (row and cells).

No need to manually add slot attribute (only data-ui5-slot and the framework manages the slot attribute properly).

Now in the

<ui5-table-cell data-ui5-slot="cells"></ui5-table-cell>

the data-ui5-slot should be specified. In the next release the cells slot will be default and the table-cell could be used like this:

<ui5-table-cell></ui5-table-cell>

You can check this issue for more information

@grknylmz grknylmz merged commit 6e01495 into grknylmz:master Feb 25, 2019
@adrian-bobev
Copy link
Contributor Author

We implemented a warning from the Web Components to tell you if you use a wrong data-ui5-slot instead of throwing an error.

This is the PR

@adrian-bobev adrian-bobev deleted the fix-sample branch February 25, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants