Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement clean_chroot to avoid host env variables like TMP to leak into the chroot #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement clean_chroot to avoid host env variables like TMP to leak into the chroot #280

wants to merge 1 commit into from

Commits on Aug 14, 2024

  1. Implement clean_chroot to avoid host env variables like TMP to leak i… 

    …nto the chroot

Some implementation notes:

If we use `env -i`, then we can no longer export shell functions.
So export -f "error_handler" had to be removed.

`PATH` needs to be set, otherwise `clean_chroot "$MNTPOINT" grub-install`
would fail, because grub-install is in /usr/sbin/grub-install in the
chroot.

http_proxy has to be passed otherwise apt-cacher-ng would be broken by
this commit.  While at it, I completed it and added https_proxy, and
ALL_PROXY there too for completeness sake.

Which environment variables are passed into the chroot is currently
hardcoded.

FTR, I was also wondering if it was better to use a similar mechanism to
the one you're using for CHROOT_VARIABLES, but that would not work
because only the chroot-script reads those. But we're not only using
that but also other calls from grml-debootstrap to chroot (now
clean_chroot), so the environment variables need to be set at the
grml-debootstrap level.

Closes: #232
    @adrelanos @mika
    adrelanos authored and mika committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    07a5fe6 View commit details
    Browse the repository at this point in the history