Skip to content

Conversation

crpb
Copy link
Contributor

@crpb crpb commented Mar 28, 2025

  • it's easier to read \ó/

Copy link
Member

@mika mika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, thanks! Not sure how backwards compatible this is (you've confirmed with bullseye according to IRC), basically LGTM, leaving the +2 to @jkirk :)

@mika mika requested review from zeha, evgeni, ft, jkirk and btittelbach March 28, 2025 12:40
@mika
Copy link
Member

mika commented Mar 28, 2025

From IRC: we seem to have issues with tmate, to be clarified :-/

@crpb
Copy link
Contributor Author

crpb commented Mar 28, 2025

Sadly it seems (fooding old) tmate isn't liking any of those {}

test@obelix:~$ grep '[{}]' /etc/tmux.conf
bind-key B if-shell '! tmux has-session -t bg' {
...
}
test@obelix:~$ tmate
lost server

ant it already complains about this new thing

if-shell "command -v hostname && hostname --help | grep -q -- -I" { set -g status-right "#[fg=green](net: #(hostname -I | sed -e 's/ [^ ]*:.*$//;s/ / | /g;s/ | $//')) #[fg=yellow]%Y-%m-%d %H:%M" } { set -g status-right '#[fg=yellow]%Y-%m-%d %H:%M' }

cb@obelix ~dls % schroot --directory=/ --user root --chroot=source:app_bookworm
obelix# wget -O /etc/tmux.conf https://raw.githubusercontent.com/grml/grml-etc-core/refs/heads/master/etc/tmux.conf
--2025-03-28 15:46:34--  https://raw.githubusercontent.com/grml/grml-etc-core/refs/heads/master/etc/tmux.conf
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 2606:50c0:8003::154, 2606:50c0:8000::154, 2606:50c0:8001::154, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2606:50c0:8003::154|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2844 (2.8K) [text/plain]
Saving to: '/etc/tmux.conf'

/etc/tmux.conf                              100%[========================================================================================>]   2.78K  --.-KB/s    in 0.003s

2025-03-28 15:46:34 (825 KB/s) - '/etc/tmux.conf' saved [2844/2844]

obelix# apt update; apt install -y tmate
....
obelix# tmate
/etc/tmux.conf:65: usage: if-shell [-bF] [-t target-pane] shell-command command [command]                                                                               [0/0]
Tip: if you wish to use tmate only for remote access, run: tmate -F
....

Maybe tmate needs to unlearn about /etc/tmux.conf 🙈

https://salsa.debian.org/debian/tmate/-/blob/upstream/tmux.h?ref_type=heads#L56

@zeha
Copy link
Member

zeha commented Aug 26, 2025

This needs at least a rebase, and also the tmate issue needs to be sorted out.

@crpb
Copy link
Contributor Author

crpb commented Oct 4, 2025

also the tmate issue needs to be sorted

thougts? https://salsa.debian.org/cb/tmate/-/commit/0dae773b26e929bb448f29a60aeb8fe0b45c42a0

@zeha
Copy link
Member

zeha commented Oct 4, 2025

did that land in forky?

i'd be ok with it being broken on trixie (if it works in forky), duno about the others.

@zeha
Copy link
Member

zeha commented Oct 4, 2025

i'd be ok with it being broken on trixie (if it works in forky), duno about the others.

on second thought, doing this for grml-etc-core would be bad. users expect better backwards compat.

@crpb
Copy link
Contributor Author

crpb commented Oct 4, 2025

did that land in forky?

no, i only created that here for me today to see if it works and it does.
but yeah, it would break even trixie if send in and then even accepted with this /etc/tmux.con

@mika
Copy link
Member

mika commented Oct 6, 2025

did that land in forky?

no, i only created that here for me today to see if it works and it does. but yeah, it would break even trixie if send in and then even accepted with this /etc/tmux.con

I'd love to have https://salsa.debian.org/cb/tmate/-/commit/0dae773b26e929bb448f29a60aeb8fe0b45c42a0 available, but I agree, we shouldn't break backwards compatibility. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants