Remove unused code from script-functions #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't check, but if any of these are in the manual page for grml's zshrc, they should be removed also. |
the zshrc config does not source script-functions. I expect them to not be in the man page, or if they are then they are already duplicated in zshrc (and will stay in there). |
|
Fair point. I assumed this was of |
|
Yeah, it's one of the long standing issue I'd like to clean up :) |
|
@mika could you take a look? |
mika
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine when we move the remaining scripts from grml-scripts into grml-live,
script-functionsshould be merged withautoconfig.functions. Until then we can at least slim this file down.