Add support for building grml ISOs with zfs #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ZFS` FAI class will, via the `instsoft.ZFS` hook, install the packages needed to build the zfs modules, build the zfs modules, then remove the development packages again to avoid bloating the ISO. The ZFS `package_config` now only installs `zfsutils-linux` so that the iso contains the userspace zfs tools. In my tests, the ZFS class now only increases the size of the ISO by about 3MB. I wanted to rely on apt autoremove to get rid of automatically installed packages, but for some reason as of 2.5.2 autoremove doesn't actually remove some of the development packages (e.g. gcc-11) even though they're Priority optional, marked as auto-installed, and not depended on by anything that isn't auto-installed. So, to avoid bloating the ISO with hundreds of MB of development packages, the `instsoft.ZFS` script works out which packages it installs and removes those explicitly, using potentially brittle parsing of `apt-get` output. This has been tested to work and should do until a better solution is found.
|
Finally had the chance to give it a try, LGTM - thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ZFSFAI class will, via theinstsoft.ZFShook, install the packagesneeded to build the zfs modules, build the zfs modules, then remove the
development packages again to avoid bloating the ISO. The ZFS
package_confignow only installszfsutils-linuxso that the iso containsthe userspace zfs tools.
In my tests, the ZFS class now only increases the size of the ISO by about
3MB.
I wanted to rely on apt autoremove to get rid of automatically installed
packages, but for some reason as of 2.5.2 autoremove doesn't actually remove
some of the development packages (e.g. gcc-11) even though they're Priority
optional, marked as auto-installed, and not depended on by anything that
isn't auto-installed.
So, to avoid bloating the ISO with hundreds of MB of development packages,
the
instsoft.ZFSscript works out which packages it installs and removesthose explicitly, using potentially brittle parsing of
apt-getoutput.This has been tested to work and should do until a better solution is found.