Drop support for all boot methods other than isolinux #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "grub2" and "manifold" options for HYBRID_METHOD as well as the "grub" and "grub2" options for BOOT_METHOD are not used by any official Grml ISO, though they add considerable overhead and complexity in our code base. I'd like to keep our code base simple and avoid feature creep, so let's deprecate BOOT_METHOD, and drop support for HYBRID_METHOD other than isolinux.
|
haven't looked at the change yet, but does it preserve uefi boot with grub2? |
zeha
reviewed
Aug 20, 2024
| @@ -152,12 +147,8 @@ | |||
| # boot the CD using normal el torito mode or copy it to USB device | |||
| # *without* having to run grml2usb (like: 'dd if=grml.iso of=/dev/sdX') | |||
| # - working both with the same ISO | |||
| # Note that the manifold method is currently not be compatible with UEFI | |||
| # setups. | |||
| # HYBRID_METHOD='disable' # do not create a hybrid ISO | |||
There was a problem hiding this comment.
is there a good reason to keep supporting disable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "grub2" and "manifold" options for HYBRID_METHOD as well as the "grub" and "grub2" options for BOOT_METHOD are not used by any official Grml ISO, though they add considerable overhead and complexity in our code base.
I'd like to keep our code base simple and avoid feature creep, so let's deprecate BOOT_METHOD, and drop support for HYBRID_METHOD other than isolinux.
Note: not yet verified myself and there's also a
TODOleft (see code changes), but trying to gather early feedback :)