Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hf datasets integration #96

Merged
merged 14 commits into from
Oct 12, 2023
Merged

Add hf datasets integration #96

merged 14 commits into from
Oct 12, 2023

Conversation

lucmos
Copy link
Member

@lucmos lucmos commented Oct 10, 2023

No description provided.

@lucmos lucmos requested a review from Flegyas October 10, 2023 10:33
@lucmos lucmos self-assigned this Oct 10, 2023
@lucmos lucmos changed the base branch from main to develop October 10, 2023 12:10
@crisostomi
Update hf_io.py
825510b 
replace if clause with 'exist_ok' flag in mkdir
@crisostomi
Update hf_io.py
fd5e226 
remove trailing whitespace
crisostomi
crisostomi approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@crisostomi crisostomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We'll probably have to implement some mechanism for having offline/pre-transforms to avoid slowing the training too much by doing everything as an online transform.

@lucmos
Copy link
Member Author

lucmos commented Oct 11, 2023

@Flegyas I think the hf_io.py can stay here for the moment, and in the release when it is stable we can move it to nn_core -- what do you think?

@lucmos lucmos mentioned this pull request Oct 12, 2023
Merged
@lucmos lucmos merged commit e22c1a3 into develop Oct 12, 2023
1 check passed
@lucmos lucmos deleted the feature/hf-integration branch October 12, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisostomi crisostomi crisostomi approved these changes

@Flegyas Flegyas Awaiting requested review from Flegyas

Assignees

@lucmos lucmos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucmos @crisostomi