FIXED: Location Being Overwritten By Default Location

[akemidx]

Default Location was overwriting the Current Location of an asset when editing that asset.

Our code was always resetting the location of an asset to the Default Location on any update. Current Location is NOT an editable field when editing an asset; it can only be done during an audit.

(The location updates, even when a user doesn't have the ability to even see the current location field) (Asset Checked Out) (Asset Checked in and set to its new current location) (Now updating an asset will not update that current location)

[what-the-diff]

PR Summary

• Simplified Asset Update Mechanism
  Previously, when editing asset details in our system, the location was getting updated which was not ideal. We've removed this automatic update mechanism to ensure that changing asset details does not inadvertently alter an asset's assigned location.

• Additional Test for Asset Editing
  To ensure this change functions as desired, a new test has been added. This will verify that the location does not get updated when an asset's details are edited — be it the name or other properties. This helps maintain accuracy in our asset tracking process.

[marcusmoore]

Paired on this 👍🏾

[snipe]

Wait, but we did that on purpose, IIRC.

[akemidx]

Wait, but we did that on purpose, IIRC.

Yea, we saw that it was an older few lines. We may be able to rework/improve this PR in another.

I do believe that the current location should not be overwritten by the default location if a current location is filled in.
What is happening under the hood, is that when you edit an asset, you can NOT edit the current location, and as such we were NEVER passign the current location in the edit asset workflow. Therefore, it would ALWAYS return null, and then ALWAYS overwrite the current location with the default location.

[snipe]

I do believe that the current location should not be overwritten by the default location if a current location is filled in.

Agreed

What is happening under the hood, is that when you edit an asset, you can NOT edit the current location

You can via checkin, audit, and bulk edit, FYI.

[akemidx]

You can via checkin, audit, and bulk edit, FYI.

tyty. ya, I know, I meant specifically the edit button for per asset