Skip to content

Commit

Permalink
lint: golangci: fix various
Browse files Browse the repository at this point in the history
  • Loading branch information
grokify committed Oct 29, 2022
1 parent 878bc9f commit d7b1c91
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 41 deletions.
3 changes: 1 addition & 2 deletions charts/d3/d3bullet/d3bullet.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package d3bullet
import (
"encoding/json"
"fmt"
"io/ioutil"
"os"
"path"

Expand Down Expand Up @@ -117,7 +116,7 @@ func ProjectionToBullet(prjData bullet.ProjectionDataInt, title string, subtitle

func GetJS() []byte {
filepath := path.Join(os.Getenv("GOPATH"), "src", JSPath)
bytes, err := ioutil.ReadFile(filepath)
bytes, err := os.ReadFile(filepath)
if err != nil {
return []byte("")
}
Expand Down
3 changes: 1 addition & 2 deletions data/documents/documents_read.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package documents

import (
"io"
"io/ioutil"
"os"

"github.com/grokify/mogo/encoding/csvutil"
Expand Down Expand Up @@ -65,5 +64,5 @@ func MergeFilterCSVFilesToJSON(inPaths []string, outPath string, inComma rune, p
if err != nil {
return err
}
return ioutil.WriteFile(outPath, bytes, perm)
return os.WriteFile(outPath, bytes, perm)
}
71 changes: 36 additions & 35 deletions data/roadmap/canvas.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,47 +163,48 @@ ITEMS:
}

/*
type Item struct {
MinTime time.Time
MaxTime time.Time
MinCell int32 // Inflated by Canvas
MaxCell int32 // Inflated by Canvas
Min int64 // Inflated by Canvas
Max int64 // Inflated by Canvas
Name string
URL string
Color string
}
func (i *Item) SetMinMaxQuarter(qtrMin, qtrMax int32) error {
if qtrMax < qtrMin {
return fmt.Errorf("Max is < min: min [%v] max [%v]", qtrMin, qtrMax)
}
err := i.SetMinQuarter(qtrMin)
if err != nil {
return err
type Item struct {
MinTime time.Time
MaxTime time.Time
MinCell int32 // Inflated by Canvas
MaxCell int32 // Inflated by Canvas
Min int64 // Inflated by Canvas
Max int64 // Inflated by Canvas
Name string
URL string
Color string
}
func (i *Item) SetMinMaxQuarter(qtrMin, qtrMax int32) error {
if qtrMax < qtrMin {
return fmt.Errorf("Max is < min: min [%v] max [%v]", qtrMin, qtrMax)
}
err := i.SetMinQuarter(qtrMin)
if err != nil {
return err
}
return i.SetMaxQuarter(qtrMax)
}
return i.SetMaxQuarter(qtrMax)
}
func (i *Item) SetMinQuarter(qtr int32) error {
qt, err := tu.QuarterInt32StartTime(qtr)
if err != nil {
return err
func (i *Item) SetMinQuarter(qtr int32) error {
qt, err := tu.QuarterInt32StartTime(qtr)
if err != nil {
return err
}
i.MinTime = qt
return nil
}
i.MinTime = qt
return nil
}
func (i *Item) SetMaxQuarter(qtr int32) error {
qt, err := tu.QuarterInt32EndTime(qtr)
if err != nil {
return err
func (i *Item) SetMaxQuarter(qtr int32) error {
qt, err := tu.QuarterInt32EndTime(qtr)
if err != nil {
return err
}
i.MaxTime = qt
return nil
}
i.MaxTime = qt
return nil
}
*/

func GetCanvasQuarter(start, end int32) (Canvas, error) {
qs, err := tu.QuarterInt32StartTime(start)
if err != nil {
Expand Down
3 changes: 1 addition & 2 deletions data/table/write.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package table
import (
"encoding/csv"
"fmt"
"io/ioutil"
"os"
"regexp"
"strconv"
Expand Down Expand Up @@ -291,5 +290,5 @@ func (tbl *Table) WriteJSON(path string, perm os.FileMode, jsonPrefix, jsonInden
if err != nil {
return err
}
return ioutil.WriteFile(path, bytes, perm)
return os.WriteFile(path, bytes, perm)
}

0 comments on commit d7b1c91

Please sign in to comment.