Organized Card stories structure #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanjida Afrin <safrin2@myseneca.ca>
Co-authored-by: Sharon Shabtai <sharons@spectralogic.com>
|
Congrats @sanji11 on your first-time contribution to grommet! Thank you for your contribution, feel free to make more contributions to help our open-source! |
ShimiSun
approved these changes
Oct 31, 2020
|
Thanks a lot for accepting my PR 😃 I am hoping to contribute more on this following issue. Also, thanks @shabtaisharon for your review. I will keep in mind on my future PR. |
|
@sanji11 great to have you on board! |
|
Sure, I will join on the slack 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Organized the
Card/storiesby type of its component which is Layout.Where should the reviewer start?
src/js/components/Card/stories/Card.stories.jsWhat testing has been done on this PR?
yarn storybookyarn testyarn prettieryarn lintHow should this be manually tested?
yarn storybookAny background context you want to provide?
No
What are the relevant issues?
#4651
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
No
Is this change backwards compatible or is it a breaking change?
This change is backwards compatible.