mda: never override any already queued messages #136
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flush id handling seems to be highly fragile for race conditions. This commit makes the fopen fail if a mess file does already exist (i.e. the user moved files from `save/` to `mess/`) and **not** override it silently.
liske
added a commit
to liske/grommunio-documentation
that referenced
this pull request
Mar 7, 2025
Using a filenames which cannot be interpreted as integer values in decimal notation without any leading zeros does not work[1]. The **only** id which can be used save seems to be `0`, other values can be overwritten due to[2] and the implementation of `message_enqueue_retrieve_max_ID`[3] which is **not** free of race conditions. So better be save than sorry. [1] grommunio/gromox#135 [2] grommunio/gromox#136 [3] https://github.com/grommunio/gromox/blob/17ca866e731a3c19a6e66491442dd68a72b0ad39/mda/message_enqueue.cpp#L328 The code has been improved: - always use `mv -n` to **never** replace existing files - do not croak if `save/` is empty
liske
added a commit
to liske/grommunio-documentation
that referenced
this pull request
Mar 7, 2025
Using a filename which cannot be interpreted as integer value in decimal notation without any leading zeros does not work[1]. The **only** id which can be used save seems to be `0`, other values can be overwritten due to [2] and the implementation of `message_enqueue_retrieve_max_ID`[3] which is **not** free of race conditions. So better be save than sorry. [1] grommunio/gromox#135 [2] grommunio/gromox#136 [3] https://github.com/grommunio/gromox/blob/17ca866e731a3c19a6e66491442dd68a72b0ad39/mda/message_enqueue.cpp#L328 The code has been improved: - always use `mv -n` to **never** replace existing files - do not croak if `save/` is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flush id handling seems to be highly fragile for race conditions. This commit makes the fopen fail if a mess file does already exist (i.e. the user moved files from
save/tomess/) and not override it silently.