Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Groovy Gradle Android 1.0.0 Update #3

Open
AndrewReitz opened this issue Jun 24, 2016 · 4 comments
Open

Groovy Gradle Android 1.0.0 Update #3

AndrewReitz opened this issue Jun 24, 2016 · 4 comments

Comments

@AndrewReitz
Copy link

With the name change in 1.0.0 I think I broke something with emerger.

There is an error message that says "You must apply the Groovy/Android plugin before using emerger plugin"

Let me know if I can help with this issue, and sorry about breaking things.

@mariogarcia
Copy link
Contributor

No worries, I was already planning to review the project during weekend.
I'll post my updates as soon as possible.

Mario
On 24 Jun 2016 15:18, "Andrew Reitz" notifications@github.com wrote:

With the name change in 1.0.0 I think I broke something with emerger.

There is an error message that says "You must apply the Groovy/Android
plugin before using emerger plugin"

Let me know if I can help with this issue, and sorry about breaking things.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3, or mute the thread
https://github.com/notifications/unsubscribe/ABWT84XbgzNQ-ORHyyGMWNstL0J3N81fks5qO9k4gaJpZM4I9wdU
.

@AndrewReitz
Copy link
Author

Any update on this? Would you need any help?

@mariogarcia
Copy link
Contributor

I'm sorry, I haven't been able to save some time for this. BTW there have been some news lately that made think about emerger.

  • Shadow plugin (https://github.com/johnrengelman/shadow) now is able to merge extension modules files.
  • I would say that somebody has to check shadow plugin in order to decide if the emerger plugin is no longer neccessary. If it works, I think the best thing to do is to declare emerger plugin as deprecated in favor of shadow plugin, which btw I guess it will have a better maintenance than emerger.

I imagine the test like adding the shadow plugin in the main android app and make the shadow merger task (check http://imperceptiblethoughts.com/shadow/#controlling_jar_content_merging) running before the android app packaging.

And thanks again for the feedback
Mario

@khurramijaz
Copy link

Only change required is the groovy gradle plugin name has changed. New name is groovyx.android.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants