Use context.result instead of $stderr.puts
#20
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easier to understand the output when a test fails.
otegami
reviewed
Feb 19, 2025
| @@ -218,7 +218,7 @@ def run_groonga(context, &block) | |||
| run_groonga_http(context, &block) | |||
| end | |||
| rescue => error | |||
| $stderr.puts("#{error.class}: #{error}") | |||
| context.result << [:error, "#{error.class}: #{error}", {}] | |||
There was a problem hiding this comment.
Grntest::Executors::BaseExecutorにprivateメソッドで、contextに結果を追加するAPIがあるのですが、
こちらをpublicに変更して利用するのはどうでしょう？
grntest/lib/grntest/executors/base-executor.rb
Lines 932 to 934 in add7c31
There was a problem hiding this comment.
それは executor が持ってるやつで、この時点だと executor を絡めるよりは context を使ったほうが良さそうと思ったんですが、そんなことはないですか？
There was a problem hiding this comment.
すみません。
改めてコードを見てみたのですが、確かにcontextを利用して上げるほうが良さそうですね！
otegami
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easier to understand the output when a test fails.