Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.1.0 claims no (potentially) breaking canges, but bumps required maven to 3.9.9 #324

Closed
aikebah opened this issue Jan 2, 2025 · 1 comment
Closed

4.1.0 claims no (potentially) breaking canges, but bumps required maven to 3.9.9 #324

aikebah opened this issue Jan 2, 2025 · 1 comment
Milestone
4.1.1

Comments

@aikebah
Copy link

aikebah commented Jan 2, 2025 •
edited
Loading

Caused by

f2c12af

that doesn't take

GMavenPlus/pom.xml

Line 175 in 7f70b93

<maven>${mavenVersion}</maven>

into account resulting in

Error: Failed to execute goal org.codehaus.gmavenplus:gmavenplus-plugin:4.1.0:execute (add-dynamic-properties-clean) on project dependency-check-parent: The plugin org.codehaus.gmavenplus:gmavenplus-plugin:4.1.0 requires Maven version 3.9.9 -> [Help 1]
@keeganwitt
Copy link
Member

keeganwitt commented Jan 2, 2025 •
edited
Loading

Oh. This was unintentional. I intended the change to affect only my tests, and not for users. You're exactly right, I missed changing line 175.

Thanks for reporting!

keeganwitt added a commit that referenced this issue Jan 2, 2025
@keeganwitt
Merge pull request #325 from groovy/fix-required-maven-version
ff57fa1 
Fix that required Maven version was accidentally bumped (closes #324)
@keeganwitt keeganwitt added this to the 4.1.1 milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
2 participants
@keeganwitt @aikebah